Merged
Conversation
Collaborator
Author
|
Just updated based on IRC:
@zpao I left the jsx config refactoring because in #200 you said "I wanted to get rid of those json files anyway." but I can get rid of it or split it out if you prefer. |
getConfig needs to be a function because grunt.config.data.pkg.version isn't available at the time that grunt/config/jsx/jsx.js is required. Test Plan: grunt build, grunt lint, grunt test all work. After building, both react.js and react.min.js contain the version number.
Member
|
👍 @benjamn Are you game to remove those config files? |
Member
|
And that's the sound of the buzzer you hear. Going to do this. We'll just have to keep an eye out for merge conflicts here but I don't think it'll be too much of an issue. Wishes do come true @tomocchino... |
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
[BLOCKED] Use new @reach/tooltip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Resubmitting since #200 got closed and reverted.)
getConfig needs to be a function because grunt.config.data.pkg.version isn't available at the time that grunt/config/jsx/jsx.js is required.
Test Plan:
grunt build, grunt lint, grunt test all work. After building, both react.js and react.min.js contain the version number.